GitHub user hy144328 added a comment to the discussion: Roadmap to SQLAlchemy 2
I have to tap out for tonight because it is getting a little late here. I have just uploaded my own PR draft for `Engine.execute()`. #41917 Would you mind taking a step back from `Engine.execute()` in #41914 ? I think I have found quite a few occurrences that are not covered by unit tests, especially `Inspector.bind` references where the presence of `Engine` is less obvious. I am aware that I still have to fix one unit test in #41917 because a mock is not working anymore. And I still have to look at all the migration scripts, which is quite repetitive and also makes up the bulk of your #41914 . I will resume tomorrow evening, and fill in the details of the PR. Would it be possible to already activate the integration tests in case I want to start debugging on those? Otherwise, I would be generally grateful if you already have some feedback in case you noticing anything as off. I have also left a comment for #41915 , which looks very good to me. Thanks as always, and talk to you tomorrow or so. GitHub link: https://github.com/apache/superset/discussions/40273#discussioncomment-17591116 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
