GitHub user rusackas added a comment to the discussion: Roadmap to SQLAlchemy 2
Didn't want to wait on this, so I dug into the actual checklist (the commented-out `error:` lines in pytest.ini) and ran the suite locally with SQLALCHEMY_WARN_20=1. As it turns out, that env var is never actually set anywhere in CI, so none of this, including the 3 categories already "locked in", has ever been enforced automatically. #41915 fixes that. Also tried to knock out a few more categories that looked like free wins from a quick grep, but two of them (`as_declarative()`, the `database` package warning) turned out to be tripped by Flask-AppBuilder's and pyhive's own code, not ours, so those stay commented out for now. The other three panned out, one needed a mechanical import-path fix across 101 files for `declarative_base()`. That's #41914. @hy144328 does this line up with what you had in mind, or do you already have more of this in flight? Don't want to step on toes. GitHub link: https://github.com/apache/superset/discussions/40273#discussioncomment-17590672 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
