bito-code-review[bot] commented on PR #41931:
URL: https://github.com/apache/superset/pull/41931#issuecomment-4934336229
<!-- Bito Reply -->
The flagged issue is correct. Passing `label={ctrl}` to `TextControl` causes
`ControlHeader` to render an additional visible label, resulting in duplication
because the component already renders a `<FormLabel>` for each control. To
resolve this, you should pass an `aria-label` instead of `label` to
`TextControl` to maintain accessibility without the visual regression.
Here is the corrected code snippet:
```tsx
value={value?.[ctrl]}
onChange={(ctrlValue: number) => handleChange(ctrl, ctrlValue)}
isFloat
aria-label={ctrl}
/>
```
I have checked the available review comments, and there are no other
comments on this pull request to address.
**superset-frontend/src/explore/components/controls/ViewportControl.tsx**
```
value={value?.[ctrl]}
onChange={(ctrlValue: number) => handleChange(ctrl, ctrlValue)}
isFloat
aria-label={ctrl}
/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
