bito-code-review[bot] commented on code in PR #41931:
URL: https://github.com/apache/superset/pull/41931#discussion_r3559267857
##########
superset-frontend/src/explore/components/controls/TextControl/index.tsx:
##########
@@ -27,6 +27,7 @@ type InputValueType = string | number;
export interface TextControlProps<T extends InputValueType = InputValueType> {
name?: string;
label?: string;
+ ariaLabel?: string;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing test coverage for ariaLabel prop</b></div>
<div id="fix">
The new `ariaLabel` prop (line 30) has zero test coverage. Per adaptive rule
[11730], new features must include unit tests covering success paths. Add a
test case verifying `ariaLabel` is rendered when provided and falls back to
`label` when omitted. Current tests only verify rendering/disabled state, not
accessibility attributes.
</div>
</div>
<small><i>Code Review Run #649d4f</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
