codeant-ai-for-open-source[bot] commented on code in PR #41502:
URL: https://github.com/apache/superset/pull/41502#discussion_r3562123258
##########
superset/commands/report/log_prune.py:
##########
@@ -41,7 +41,7 @@ def run(self) -> None:
for report_schedule in db.session.query(ReportSchedule).all():
if report_schedule.log_retention is not None:
- from_date = datetime.utcnow() - timedelta(
+ from_date = datetime.now(timezone.utc).replace(tzinfo=None) -
timedelta(
days=report_schedule.log_retention
)
Review Comment:
**Suggestion:** Add an explicit type annotation to this newly introduced
local datetime variable to satisfy the type-hint requirement for relevant
variables. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new local variable `from_date` is introduced without an explicit type
annotation, and its type is clearly inferable as a datetime. This matches the
rule requiring type hints for relevant variables that can be annotated.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f56648b9603d4641a29b91337f42567b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f56648b9603d4641a29b91337f42567b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/log_prune.py
**Line:** 44:46
**Comment:**
*Custom Rule: Add an explicit type annotation to this newly introduced
local datetime variable to satisfy the type-hint requirement for relevant
variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=7859e890528c01cdcc31f8c798651ba2d8f1a5626c58e23b7ff1aa775d588bec&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=7859e890528c01cdcc31f8c798651ba2d8f1a5626c58e23b7ff1aa775d588bec&reaction=dislike'>๐</a>
##########
superset/daos/query.py:
##########
@@ -48,7 +48,9 @@ def save_metadata(query: Query, payload: dict[str, Any]) ->
None:
@staticmethod
def get_queries_changed_after(last_updated_ms: Union[float, int]) ->
list[Query]:
# UTC date time, same that is stored in the DB.
- last_updated_dt = datetime.utcfromtimestamp(last_updated_ms / 1000)
+ last_updated_dt = datetime.fromtimestamp(
+ last_updated_ms / 1000, timezone.utc
+ ).replace(tzinfo=None)
Review Comment:
**Suggestion:** Add an explicit type annotation to this newly introduced
local datetime variable to satisfy the projectโs type-hint requirement.
[custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new local variable `last_updated_dt` is introduced without a type
annotation, and the rule explicitly requires type hints on newly added Python
variables that can be annotated. This is a real violation in the added code.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=2ed8c175944a4895a0d34fc86623aed2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=2ed8c175944a4895a0d34fc86623aed2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/daos/query.py
**Line:** 51:53
**Comment:**
*Custom Rule: Add an explicit type annotation to this newly introduced
local datetime variable to satisfy the projectโs type-hint requirement.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=1ac68caffbb4c0a04df918b02888e1fb5a4e16e40e32f6fb0f7a3d2bdbb617e8&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=1ac68caffbb4c0a04df918b02888e1fb5a4e16e40e32f6fb0f7a3d2bdbb617e8&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
