codeant-ai-for-open-source[bot] commented on code in PR #41502:
URL: https://github.com/apache/superset/pull/41502#discussion_r3564113606
##########
superset/commands/report/execute.py:
##########
@@ -736,15 +746,19 @@ def _get_csv_data(self) -> bytes:
self._execution_id,
)
except SoftTimeLimitExceeded as ex:
- elapsed_seconds = (datetime.utcnow() - start_time).total_seconds()
+ elapsed_seconds = (
+ datetime.now(timezone.utc).replace(tzinfo=None) - start_time
+ ).total_seconds()
Review Comment:
**Suggestion:** Add an explicit type annotation for this newly added
elapsed-time variable in the exception path. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The exception-path timing variable is newly added and unannotated. Since it
is a simple local duration value, it can be type-hinted, so this is a real
violation of the Python type-hint rule.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=550c719571a64fb580763cd79e1d46c1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=550c719571a64fb580763cd79e1d46c1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 749:751
**Comment:**
*Custom Rule: Add an explicit type annotation for this newly added
elapsed-time variable in the exception path.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=e747489474ed891085da47c72406cf2df5605fd361c45b42964d2291819ea726&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=e747489474ed891085da47c72406cf2df5605fd361c45b42964d2291819ea726&reaction=dislike'>๐</a>
##########
superset/commands/report/execute.py:
##########
@@ -786,15 +802,19 @@ def _get_embedded_data(self) -> pd.DataFrame:
self._execution_id,
)
except SoftTimeLimitExceeded as ex:
- elapsed_seconds = (datetime.utcnow() - start_time).total_seconds()
+ elapsed_seconds = (
+ datetime.now(timezone.utc).replace(tzinfo=None) - start_time
+ ).total_seconds()
Review Comment:
**Suggestion:** Add a concrete type hint to this new `elapsed_seconds`
assignment to satisfy the rule for annotating relevant variables. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This is another newly added local timing variable without a type hint. The
code clearly can annotate the duration value, so the suggestion correctly
identifies a type-hint omission.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=1df59ae466774fc087af1c4a3528768d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=1df59ae466774fc087af1c4a3528768d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 805:807
**Comment:**
*Custom Rule: Add a concrete type hint to this new `elapsed_seconds`
assignment to satisfy the rule for annotating relevant variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=775f371440817bc52cba535d24f01f0725c580fb411471c9307c563cac7977fc&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=775f371440817bc52cba535d24f01f0725c580fb411471c9307c563cac7977fc&reaction=dislike'>๐</a>
##########
superset/commands/report/execute.py:
##########
@@ -558,22 +560,28 @@ def _get_screenshots(self) -> list[bytes]:
"Screenshot failed; aborting to avoid sending a
partial report"
)
imges.append(imge)
- elapsed_seconds = (datetime.utcnow() - start_time).total_seconds()
+ elapsed_seconds = (
+ datetime.now(timezone.utc).replace(tzinfo=None) - start_time
+ ).total_seconds()
Review Comment:
**Suggestion:** Add an explicit type annotation for this new timing variable
to comply with the typed-local-variable requirement. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This new local variable is introduced without a type annotation, and it can
clearly be annotated as a numeric duration. That matches the rule requiring
type hints for relevant variables in new or modified Python code.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=34535a5995dc4492ba0d8db1e788ecdb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=34535a5995dc4492ba0d8db1e788ecdb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 563:565
**Comment:**
*Custom Rule: Add an explicit type annotation for this new timing
variable to comply with the typed-local-variable requirement.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=a9b674c7d5a7e9a19ecc36a39347f253c6c3e0b88bb764449af9844237a95704&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=a9b674c7d5a7e9a19ecc36a39347f253c6c3e0b88bb764449af9844237a95704&reaction=dislike'>๐</a>
##########
superset/commands/report/execute.py:
##########
@@ -1192,7 +1212,10 @@ def next(self) -> None:
self._report_schedule
)
elapsed_seconds = (
- (datetime.utcnow() - last_working.end_dttm).total_seconds()
+ (
+ datetime.now(timezone.utc).replace(tzinfo=None)
+ - last_working.end_dttm
+ ).total_seconds()
if last_working
else None
)
Review Comment:
**Suggestion:** Annotate this newly added elapsed-time local variable with
its type for consistency with strict typing requirements. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new elapsed-time calculation is introduced without an annotation.
Because it is a local variable with a clear numeric type, this falls under the
rule requiring type hints for relevant variables.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=25ebac231f514f77a9bf7f0b37e719f6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=25ebac231f514f77a9bf7f0b37e719f6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 1214:1221
**Comment:**
*Custom Rule: Annotate this newly added elapsed-time local variable
with its type for consistency with strict typing requirements.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=a08e7bd695cda00e5f658668d8f7ac7396364c00bdb3e2c0ec8a35692af9fc72&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=a08e7bd695cda00e5f658668d8f7ac7396364c00bdb3e2c0ec8a35692af9fc72&reaction=dislike'>๐</a>
##########
superset/commands/report/execute.py:
##########
@@ -1409,7 +1432,9 @@ def run(self) -> None:
self._execution_id, self._model, self._scheduled_dttm
).run()
- elapsed_seconds = (datetime.utcnow() - start_time).total_seconds()
+ elapsed_seconds = (
+ datetime.now(timezone.utc).replace(tzinfo=None) - start_time
+ ).total_seconds()
Review Comment:
**Suggestion:** Add a type annotation to this new local duration variable
introduced in the command execution flow. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This final added timing variable is also unannotated, even though it is a
straightforward local value that can be typed. That is a genuine instance of
the custom type-hint rule violation.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=967c5fc062cc4e56a4018c1d949c9d2b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=967c5fc062cc4e56a4018c1d949c9d2b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 1435:1437
**Comment:**
*Custom Rule: Add a type annotation to this new local duration variable
introduced in the command execution flow.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=491ac7170951bfb488617354b22f028be1f7d467d54feb537c5112aebd396271&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=491ac7170951bfb488617354b22f028be1f7d467d54feb537c5112aebd396271&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
