codeant-ai-for-open-source[bot] commented on code in PR #41502:
URL: https://github.com/apache/superset/pull/41502#discussion_r3562125544
##########
superset/commands/report/execute.py:
##########
@@ -511,7 +513,7 @@ def _get_screenshots(self) -> list[bytes]:
Get chart or dashboard screenshots
:raises: ReportScheduleScreenshotFailedError
"""
- start_time = datetime.utcnow()
+ start_time = datetime.now(timezone.utc).replace(tzinfo=None)
Review Comment:
**Suggestion:** Add a type annotation for this newly introduced local
variable so timing values are explicitly typed. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This newly added timing local is unannotated even though its value is
clearly a datetime and can be typed. The rule requires type hints on relevant
variables that can be annotated.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=8dd3076e4f934db490916bfe8d25dad8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=8dd3076e4f934db490916bfe8d25dad8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 516:516
**Comment:**
*Custom Rule: Add a type annotation for this newly introduced local
variable so timing values are explicitly typed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=607d8f14673629c6ba8aec6bd98621729b08049b660677781dbd00680217706d&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=607d8f14673629c6ba8aec6bd98621729b08049b660677781dbd00680217706d&reaction=dislike'>๐</a>
##########
superset/commands/report/execute.py:
##########
@@ -134,7 +134,7 @@ def __init__(
) -> None:
self._report_schedule = report_schedule
self._scheduled_dttm = scheduled_dttm
- self._start_dttm = datetime.utcnow()
+ self._start_dttm = datetime.now(timezone.utc).replace(tzinfo=None)
Review Comment:
**Suggestion:** Add an explicit type annotation for this instance attribute
when it is initialized to comply with the type-hint requirement. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new instance attribute is introduced without a type annotation, and it
can be annotated as a datetime value. This matches the type-hint requirement
for modified Python code.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e27feef702f84f71b58d69ede0326509&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e27feef702f84f71b58d69ede0326509&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 137:137
**Comment:**
*Custom Rule: Add an explicit type annotation for this instance
attribute when it is initialized to comply with the type-hint requirement.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=2ba7dcb2b9e42882e98bc563ccb07ccc1087c6f7eba7f2a74e31e75623844f79&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=2ba7dcb2b9e42882e98bc563ccb07ccc1087c6f7eba7f2a74e31e75623844f79&reaction=dislike'>๐</a>
##########
superset/utils/cache.py:
##########
@@ -226,7 +226,7 @@ def wrapper(*args: Any, **kwargs: Any) -> Response: #
noqa: C901
# Check if the cache is stale. Default the content_changed_time to
now
# if we don't know when it was last modified.
- content_changed_time = datetime.utcnow()
+ content_changed_time =
datetime.now(timezone.utc).replace(tzinfo=None)
if get_last_modified:
Review Comment:
**Suggestion:** Add an explicit type annotation for this new datetime
variable so the modified code remains fully type-annotated. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The rule requires type hints for new or modified Python variables that can
be annotated. This newly introduced local variable has no annotation, so the
suggestion is valid.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b535cd1547e546d886502ed920144f49&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b535cd1547e546d886502ed920144f49&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/utils/cache.py
**Line:** 230:230
**Comment:**
*Custom Rule: Add an explicit type annotation for this new datetime
variable so the modified code remains fully type-annotated.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=30aae144c37134c5692816b3c519e2aadb88eb93ee9475f405455f8b2a5ee9d7&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=30aae144c37134c5692816b3c519e2aadb88eb93ee9475f405455f8b2a5ee9d7&reaction=dislike'>๐</a>
##########
superset/commands/report/execute.py:
##########
@@ -699,7 +707,7 @@ def _post_chart_data(
return content or None
def _get_csv_data(self) -> bytes:
- start_time = datetime.utcnow()
+ start_time = datetime.now(timezone.utc).replace(tzinfo=None)
Review Comment:
**Suggestion:** Add a type annotation for this newly added `start_time`
variable in the CSV path to satisfy the rule requiring type hints. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This added local variable is not type-annotated despite being a datetime
timestamp used for elapsed-time calculations. That is a real omission under the
type-hint rule.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c66d44373dba49678696b179ae379703&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c66d44373dba49678696b179ae379703&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 710:710
**Comment:**
*Custom Rule: Add a type annotation for this newly added `start_time`
variable in the CSV path to satisfy the rule requiring type hints.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=951a28f2140895991168483157b4ea922ccab7b2f4812cd0a38ab2e3e7029a91&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=951a28f2140895991168483157b4ea922ccab7b2f4812cd0a38ab2e3e7029a91&reaction=dislike'>๐</a>
##########
superset/commands/report/execute.py:
##########
@@ -1390,7 +1413,7 @@ def run(self) -> None:
)
user = security_manager.find_user(username)
- start_time = datetime.utcnow()
+ start_time = datetime.now(timezone.utc).replace(tzinfo=None)
Review Comment:
**Suggestion:** Add a type annotation to this newly introduced `start_time`
variable in the command execution flow. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The run method introduces a new local variable for timing without any
annotation, and it is straightforwardly typeable. This is a valid type-hint
rule violation.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=35e2b9c2163e4280845283796293c3f6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=35e2b9c2163e4280845283796293c3f6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 1416:1416
**Comment:**
*Custom Rule: Add a type annotation to this newly introduced
`start_time` variable in the command execution flow.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=cb14960e6894b74865c9e0ed68f5339b4ad3ef8afed83a9f41458e91905182b5&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=cb14960e6894b74865c9e0ed68f5339b4ad3ef8afed83a9f41458e91905182b5&reaction=dislike'>๐</a>
##########
superset/commands/report/execute.py:
##########
@@ -761,7 +775,7 @@ def _get_embedded_data(self) -> pd.DataFrame:
"""
Return data as a Pandas dataframe, to embed in notifications as a
table.
"""
- start_time = datetime.utcnow()
+ start_time = datetime.now(timezone.utc).replace(tzinfo=None)
Review Comment:
**Suggestion:** Add an explicit type hint for this new `start_time` variable
in the embedded-data path. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This new local timing variable is also unannotated and can be typed as a
datetime. The custom rule explicitly flags such missing type hints.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=2cebea2296424f78834e8619a2dff6df&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=2cebea2296424f78834e8619a2dff6df&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 778:778
**Comment:**
*Custom Rule: Add an explicit type hint for this new `start_time`
variable in the embedded-data path.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=3fb597f967f8c48a764166b3de52a9846782dc494203a447f1e9010e74479e4c&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41502&comment_hash=3fb597f967f8c48a764166b3de52a9846782dc494203a447f1e9010e74479e4c&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
