rusackas opened a new pull request, #41962:
URL: https://github.com/apache/superset/pull/41962

   ### SUMMARY
   
   Test-only PR reproducing 
[#30270](https://github.com/apache/superset/issues/30270) — "Wrong 
visualization of missing values in radar charts".
   
   The Radar `transformProps` normalizes each series value with `null / max` in 
`normalizeArray`. Because `null` coerces to `0` in that division, a **missing 
(null) metric value is silently turned into `0`** and plotted at the center of 
the radar as if it were a real zero, instead of being left out as a gap.
   
   This adds a regression test to the existing 
`plugins/plugin-chart-echarts/test/Radar/transformProps.test.ts` that feeds a 
datum with one `null` metric and asserts the null is preserved in the 
normalized series value (not converted to `0`).
   
   No production code is changed — this PR only proves the bug reproduces on 
`master`.
   
   ### How to interpret CI
   
   This is a faithful red test: it asserts the **correct** behavior (a null 
metric should stay `null`/`undefined`, not become `0`).
   
   - **Expected on `master`: the new test FAILS (red).** That is the point — it 
demonstrates the bug. On `master` the null value normalizes to `0`.
   - Once a fix preserves nulls through normalization, the test will pass 
(green).
   - All 9 pre-existing Radar `transformProps` tests still pass, confirming the 
harness and fixtures are sound.
   
   ### TESTING INSTRUCTIONS
   
   ```bash
   cd superset-frontend
   npx jest plugins/plugin-chart-echarts/test/Radar/transformProps.test.ts
   ```
   
   The `missing (null) values › preserves a null metric instead of plotting it 
as 0` case fails on `master`, showing the received value is `0`.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue: Closes #30270
   - [x] Required feature flags: N/A
   - [x] Changes UI: No
   - [x] Introduces new feature or API: No
   - [x] Removes existing feature or API: No
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to