bito-code-review[bot] commented on code in PR #41962:
URL: https://github.com/apache/superset/pull/41962#discussion_r3565811801
##########
superset-frontend/plugins/plugin-chart-echarts/src/Radar/utils.ts:
##########
@@ -73,7 +73,14 @@ export const renderNormalizedTooltip = (
return {
metric,
- value: formatter ? formatter(originalValue) : originalValue,
+ // A missing metric stays null; show it plainly rather than running it
+ // through the formatter, which would render a misleading "NaN".
+ value:
+ originalValue == null
+ ? 'N/A'
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing i18n translation wrapper</b></div>
<div id="fix">
Wrap the hardcoded 'N/A' string with t('N/A') to enable translation support;
ensure t is imported from '@superset-ui/core'.
</div>
</div>
<small><i>Code Review Run #9ecb3f</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
