bito-code-review[bot] commented on PR #41962:
URL: https://github.com/apache/superset/pull/41962#issuecomment-4949301047
<!-- Bito Reply -->
The suggestion to replace the single-case `describe()` block with a
standalone `test()` is correct and aligns with standard testing best practices
to avoid unnecessary nesting. You can resolve this by removing the
`describe('missing (null) values', () => { ... })` wrapper and renaming the
inner `test` to describe the scenario more comprehensively, such as
`test('Radar chart preserves null metric values instead of plotting them as 0',
() => { ... })`.
Would you like me to implement this change for you? I can also check the
rest of the PR for similar instances if you would like me to proceed with a
broader cleanup.
**superset-frontend/plugins/plugin-chart-echarts/test/Radar/transformProps.test.ts**
```
test('Radar chart preserves null metric values instead of plotting them as
0', () => {
// ... setup code ...
const result = transformProps(missingValueProps as EchartsRadarChartProps);
// ... assertions ...
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
