bito-code-review[bot] commented on code in PR #41981: URL: https://github.com/apache/superset/pull/41981#discussion_r3567084788
########## pytest.ini: ########## @@ -40,7 +40,7 @@ filterwarnings = # error:The connection.execute\(\) method:sqlalchemy.exc.RemovedIn20Warning # error:The current statement is being autocommitted using implicit autocommit:sqlalchemy.exc.RemovedIn20Warning # error:The `database` package is deprecated:sqlalchemy.exc.RemovedIn20Warning -# error:The ``declarative_base\(\)`` function is now available:sqlalchemy.exc.RemovedIn20Warning + error:The ``declarative_base\(\)`` function is now available:sqlalchemy.exc.RemovedIn20Warning Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Unmet migration prerequisite</b></div> <div id="fix"> Uncommenting this line converts the `declarative_base()` deprecation warning into a hard test failure. The project is pinned to `sqlalchemy>=1.4.0,<2.0` (confirmed in superset-core/pyproject.toml:49), yet `declarative_base()` is used 106 times across tests, migrations, and shared modules. With this line active, pytest will fail immediately on all test runs. Keep this commented until the codebase migrates to SQLAlchemy 2.0 and replaces `declarative_base()` calls. </div> </div> <small><i>Code Review Run #ac712a</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
