bito-code-review[bot] commented on code in PR #41981: URL: https://github.com/apache/superset/pull/41981#discussion_r3567094025
########## pytest.ini: ########## @@ -40,7 +40,7 @@ filterwarnings = # error:The connection.execute\(\) method:sqlalchemy.exc.RemovedIn20Warning # error:The current statement is being autocommitted using implicit autocommit:sqlalchemy.exc.RemovedIn20Warning # error:The `database` package is deprecated:sqlalchemy.exc.RemovedIn20Warning -# error:The ``declarative_base\(\)`` function is now available:sqlalchemy.exc.RemovedIn20Warning + error:The ``declarative_base\(\)`` function is now available:sqlalchemy.exc.RemovedIn20Warning Review Comment: <!-- Bito Reply --> The reviewer's suggestion is correct regarding the potential for test failures. While `declarative_base` is available in `sqlalchemy.orm` in version 2.0, the project is currently pinned to `sqlalchemy>=1.4.0,<2.0`. In the 1.4 series, using `declarative_base()` triggers a `RemovedIn20Warning`, and uncommenting the line in `pytest.ini` converts this warning into a hard test failure, which would break the build given the current codebase usage. **pytest.ini** ``` error:The ``declarative_base\(\)`` function is now available:sqlalchemy.exc.RemovedIn20Warning ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
