bito-code-review[bot] commented on code in PR #41981: URL: https://github.com/apache/superset/pull/41981#discussion_r3567094667
########## pytest.ini: ########## @@ -40,7 +40,7 @@ filterwarnings = # error:The connection.execute\(\) method:sqlalchemy.exc.RemovedIn20Warning # error:The current statement is being autocommitted using implicit autocommit:sqlalchemy.exc.RemovedIn20Warning # error:The `database` package is deprecated:sqlalchemy.exc.RemovedIn20Warning -# error:The ``declarative_base\(\)`` function is now available:sqlalchemy.exc.RemovedIn20Warning + error:The ``declarative_base\(\)`` function is now available:sqlalchemy.exc.RemovedIn20Warning Review Comment: <!-- Bito Reply --> The reviewer's concern is that uncommenting the line in `pytest.ini` will cause all tests to fail because the project is currently pinned to SQLAlchemy 1.4.x, where `declarative_base()` triggers a `RemovedIn20Warning`. While the function is available in `sqlalchemy.orm` in version 2.0, the current environment treats this specific warning as a hard error, which would break the build. Therefore, the suggestion to keep the line commented is appropriate until the project migrates to SQLAlchemy 2.0. **pytest.ini** ``` error:The ``declarative_base\(\)`` function is now available:sqlalchemy.exc.RemovedIn20Warning ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
