bito-code-review[bot] commented on code in PR #41914: URL: https://github.com/apache/superset/pull/41914#discussion_r3573740064
########## pytest.ini: ########## @@ -37,10 +37,10 @@ filterwarnings = # error:"TaggedObject" object is being merged into a Session:sqlalchemy.exc.RemovedIn20Warning # error:The ``as_declarative\(\)`` function is now available:sqlalchemy.exc.RemovedIn20Warning # error:The autoload parameter is deprecated:sqlalchemy.exc.RemovedIn20Warning -# error:The connection.execute\(\) method:sqlalchemy.exc.RemovedIn20Warning + error:The connection.execute\(\) method:sqlalchemy.exc.RemovedIn20Warning Review Comment: <div> <div id="suggestion"> <div id="issue"><b>SQLAlchemy 2.0 migration order</b></div> <div id="fix"> Uncommenting these `error:` filters converts SQLAlchemy `RemovedIn20Warning` warnings to errors, which will break the test suite. The codebase has 65+ instances of `connection.execute()` with raw SQL (security/manager.py, metadb.py, migrations, tests) and 208+ instances of `declarative_base` in migrations. Either keep these commented during ongoing migration or fix the deprecated patterns first. </div> </div> <small><i>Code Review Run #8230f8</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
