bito-code-review[bot] commented on code in PR #41914: URL: https://github.com/apache/superset/pull/41914#discussion_r3584513531
########## pytest.ini: ########## @@ -37,10 +37,10 @@ filterwarnings = # error:"TaggedObject" object is being merged into a Session:sqlalchemy.exc.RemovedIn20Warning # error:The ``as_declarative\(\)`` function is now available:sqlalchemy.exc.RemovedIn20Warning # error:The autoload parameter is deprecated:sqlalchemy.exc.RemovedIn20Warning -# error:The connection.execute\(\) method:sqlalchemy.exc.RemovedIn20Warning + error:The connection.execute\(\) method:sqlalchemy.exc.RemovedIn20Warning Review Comment: <!-- Bito Reply --> The reviewer's concern regarding the `connection.execute()` filter is noted. Since the filter was already present in the configuration and the deprecated `sqlalchemy.ext.declarative` import path has been removed, the current configuration correctly aligns with the SQLAlchemy 2.0 migration requirements. Proceeding with the current changes is appropriate as the test suite will validate the configuration. **pytest.ini** ``` error:The connection.execute() method:sqlalchemy.exc.RemovedIn20Warning ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
