rusackas commented on code in PR #41914: URL: https://github.com/apache/superset/pull/41914#discussion_r3584513024
########## pytest.ini: ########## @@ -37,10 +37,10 @@ filterwarnings = # error:"TaggedObject" object is being merged into a Session:sqlalchemy.exc.RemovedIn20Warning # error:The ``as_declarative\(\)`` function is now available:sqlalchemy.exc.RemovedIn20Warning # error:The autoload parameter is deprecated:sqlalchemy.exc.RemovedIn20Warning -# error:The connection.execute\(\) method:sqlalchemy.exc.RemovedIn20Warning + error:The connection.execute\(\) method:sqlalchemy.exc.RemovedIn20Warning Review Comment: I don't think this holds. The `connection.execute()` filter was already uncommented before this PR, so that one's not new here. And the `declarative_base` warning only fires on the deprecated `sqlalchemy.ext.declarative` import path, which is gone. Everything that's left, migrations included, pulls `declarative_base` from `sqlalchemy.orm`, which doesn't warn. That's exactly what this PR is locking in. CI'll catch me if I'm wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
