rusackas commented on PR #41505: URL: https://github.com/apache/superset/pull/41505#issuecomment-4965818303
Thanks @mysticalayushi. The rewritten tests only check `not.toThrow()`, so they still don't verify minutes/seconds actually survive, which was the point of the original ask. `test/utils/formatters.test.ts` already asserts real formatted output for `getXAxisFormatter` (which wraps this same formatter), worth following that pattern here instead of the weaker checks in the new file. Bito's still flagging the same 4 lines, mind resolving those too? Thanks for helping to see this through! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
