rusackas commented on PR #41505: URL: https://github.com/apache/superset/pull/41505#issuecomment-4997242327
@mysticalayushi no special setup needed, to answer your question. `TimeFormatter` instances are directly callable and return real strings with no registry/configure() step. `test/utils/formatters.test.ts` already asserts on real output for `getXAxisFormatter`. Can you swap the four `not.toThrow()` checks in `formatters.test.ts` (MINUTE/FIFTEEN_MINUTES/HOUR/SECOND) for assertions on the actual formatted minute/second values, and resolve Bito's corresponding threads above once done? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
