mysticalayushi commented on PR #41505: URL: https://github.com/apache/superset/pull/41505#issuecomment-4965967018
Hi @rusackas, before I push the updated behavioral tests, I wanted to check - the previous version of these tests failed in CI because getSmartDateFormatter was returning "smart_date" as a stub for every input regardless of the date. Is there a specific setup (like calling configure() or registering the formatter) needed before the tests to make the real formatter work in the CI environment? I want to make sure the new tests pass CI before pushing. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
