bito-code-review[bot] commented on code in PR #41922: URL: https://github.com/apache/superset/pull/41922#discussion_r3583748115
########## superset/mcp_service/app.py: ########## @@ -216,6 +224,10 @@ def get_default_instructions( Available Resources: - instance://metadata: Instance configuration, stats, and available dataset IDs - chart://configs: Valid chart configuration examples and best practices +- superset://schema/chart: Filterable/sortable/select columns for the chart model +- superset://schema/dataset: Filterable/sortable/select columns for the dataset model +- superset://schema/dashboard: Filterable/sortable/select columns for the dashboard model +- superset://schema/all: Combined schema metadata for chart, dataset, and dashboard Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing unit tests for schema resources</b></div> <div id="fix"> Add unit tests covering request validation, success paths, error handling, and URI pattern matching for the new schema discovery resources in `superset/mcp_service/system/resources/schema_discovery.py`. </div> </div> <small><i>Code Review Run #b950b5</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
