aminghadersohi commented on code in PR #41922: URL: https://github.com/apache/superset/pull/41922#discussion_r3589105262
########## superset/mcp_service/app.py: ########## @@ -216,6 +224,10 @@ def get_default_instructions( Available Resources: - instance://metadata: Instance configuration, stats, and available dataset IDs - chart://configs: Valid chart configuration examples and best practices +- superset://schema/chart: Filterable/sortable/select columns for the chart model +- superset://schema/dataset: Filterable/sortable/select columns for the dataset model +- superset://schema/dashboard: Filterable/sortable/select columns for the dashboard model +- superset://schema/all: Combined schema metadata for chart, dataset, and dashboard Review Comment: Added unit tests for the schema discovery resources in `tests/unit_tests/mcp_service/system/resources/test_schema_discovery.py` (commit 0f98930c9e). Coverage includes: - URI/registration: all four `superset://schema/*` resources are discoverable via `list_resources` - Success paths: chart/dataset/dashboard resources and the combined `all` resource, asserting column metadata shape and expected default/sort/search fields - Error handling: reading an unregistered URI raises `McpError`, and `_build_schema_resource` returns an empty dict for an unknown model type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
