bito-code-review[bot] commented on code in PR #41922: URL: https://github.com/apache/superset/pull/41922#discussion_r3589106385
########## superset/mcp_service/app.py: ########## @@ -216,6 +224,10 @@ def get_default_instructions( Available Resources: - instance://metadata: Instance configuration, stats, and available dataset IDs - chart://configs: Valid chart configuration examples and best practices +- superset://schema/chart: Filterable/sortable/select columns for the chart model +- superset://schema/dataset: Filterable/sortable/select columns for the dataset model +- superset://schema/dashboard: Filterable/sortable/select columns for the dashboard model +- superset://schema/all: Combined schema metadata for chart, dataset, and dashboard Review Comment: <!-- Bito Reply --> The suggestion to add unit tests for the schema discovery resources is appropriate and has been addressed by the implementation of the requested tests in `tests/unit_tests/mcp_service/system/resources/test_schema_discovery.py`. Since the suggestion correctly identified a missing testing requirement for the new functionality, it is not necessary to avoid such suggestions in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
