devsarthak2005 commented on PR #41804: URL: https://github.com/apache/superset/pull/41804#issuecomment-4977641229
Nice fix! One minor suggestion: since ClickHouse can expose wrapped UUID types (e.g. LowCardinality(UUID) or LowCardinality(Nullable(UUID))), would it be worth adding one of those as an extra parameterized test case to ensure the UUID detection continues to work if wrapped types are reported by the dialect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
