rusackas commented on PR #41804: URL: https://github.com/apache/superset/pull/41804#issuecomment-5007445885
Thanks @yousoph, that was exactly the right thing to poke at. You're right that the SQLite tests only prove the `Cast` node gets emitted, not that the engines actually swallow it, so I ran it live on both. On Postgres 17, `event_id ILIKE 'abc%'` against a raw `uuid` column blows up with `operator does not exist: uuid ~~* unknown`, and `CAST(event_id AS VARCHAR) ILIKE 'abc%'` returns the row. On ClickHouse 26.6 the raw filter reproduces the exact error from the issue (`Illegal type UUID of argument of function ilike`), and `CAST(event_id AS String) ILIKE` works. So the fix holds on both. The layering call is made too, this already Closes #41851 (the frontend exclude-from-search take), so we won't land both. The `Map(String, UUID)` match and the MSSQL uppercase-GUID thing are real but harmless like you said, so leaving those. Thanks for the careful pass! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
