bito-code-review[bot] commented on PR #40635:
URL: https://github.com/apache/superset/pull/40635#issuecomment-4985874282
<!-- Bito Reply -->
The flagged issue is correct. In gettext, `%%` in a `msgid` is often used to
escape a literal percent sign, but if the source code uses `t('%
calculation')`, the translation catalog must contain `msgid "% calculation"` to
match the runtime key. The current PR diff shows that these entries were
changed to `%% calculation`, `%% of parent`, and `%% of total`, which will
cause the translation lookup to fail at runtime.
To resolve this, you should revert these specific `msgid` entries in the
translation files back to their single-percent form (e.g., `msgid "%
calculation"`) so they match the source code strings. Since this is a
translation catalog issue, you should update the corresponding `.po` files and
ensure the `messages.pot` template is updated accordingly.
**superset/translations/fr/LC_MESSAGES/messages.po**
```
#, python-format
msgid "% calculation"
msgstr "% calcul"
#, python-format
msgid "% of parent"
msgstr "% du parent"
#, python-format
msgid "% of total"
msgstr "% du total"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
