rusackas commented on PR #40635:
URL: https://github.com/apache/superset/pull/40635#issuecomment-5008688888
Thanks @ytihianine, and to answer your question: no frontend changes needed.
The fix is to keep those msgids single-`%` with the `#, no-python-format`
flag, as they are on master. `t('% calculation')` looks up the catalog by the
exact source string, so the `%%` versions in the .pot/.po will never match at
runtime, for any locale.
The other codeant flags on `messages.po` look legit too (`Diagramme
cartographique\"es`, `Colour de la mesure`, the semantic-views error translated
as an SQL one, and the metric minimum help text saying `valeur maximale`), so
worth a pass to address/resolve those threads.
Pre-commit is also red on a missing trailing newline in the .po, and the
branch needs a rebase. We'll re-review once those land! Let me know if you want
help with any of this, I'd love to see it through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
