codeant-ai-for-open-source[bot] commented on code in PR #40635: URL: https://github.com/apache/superset/pull/40635#discussion_r3597633024
########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -1732,9 +1692,8 @@ msgstr "Une erreur s'est produite durant l'accès à l'extension." msgid "An error occurred while accessing the value." msgstr "Une erreur s'est produite durant l'accès à la valeur." -#, fuzzy msgid "An error occurred while adding semantic views" -msgstr "Une erreur s'est produite durant le chargement de SQL" +msgstr "Une erreur s'est produite lors du chargement de SQL" Review Comment: **Suggestion:** The translation for this error key refers to SQL loading instead of semantic views, which contradicts the source message and will show users the wrong failure context. Update the `msgstr` so it accurately describes an error adding semantic views. [comment mismatch] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Semantic view errors show misleading French message. - ⚠️ French users misdiagnose semantic layer failures. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. In the gettext template `superset/translations/messages.pot` at lines 1532-1533, the source string for the error is defined as `msgid "An error occurred while adding semantic views"`, indicating the message is used when adding semantic views fails. 2. In the French catalog `superset/translations/fr/LC_MESSAGES/messages.po` at line 1696, the corresponding `msgstr` is `"Une erreur s'est produite lors du chargement de SQL"`, which instead describes an SQL loading error. 3. When the semantic view creation/update flow triggers this error (any backend call using the `msgid "An error occurred while adding semantic views"`), the i18n layer looks up the French translation from `messages.po:1696`. 4. A French user sees an error about "chargement de SQL" while the actual failure is adding semantic views, leading to incorrect mental model and potentially misdirected troubleshooting. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=fac3ee72367c4027b49c851ceebc900e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=fac3ee72367c4027b49c851ceebc900e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 1696:1696 **Comment:** *Comment Mismatch: The translation for this error key refers to SQL loading instead of semantic views, which contradicts the source message and will show users the wrong failure context. Update the `msgstr` so it accurately describes an error adding semantic views. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=bf8140d2f022696d48946b51f17b05a80e4d11fbdf16d37a0ea408ee1f72bb53&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=bf8140d2f022696d48946b51f17b05a80e4d11fbdf16d37a0ea408ee1f72bb53&reaction=dislike'>👎</a> ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -3023,7 +2956,7 @@ msgid "Captcha" msgstr "Captcha" msgid "Cartodiagram" -msgstr "Diagramme cartographique" +msgstr "Diagramme cartographique\"es" Review Comment: **Suggestion:** This translation contains an obvious malformed suffix and stray quote (`\"es`), producing broken UI text. Replace it with a clean French term for cartodiagram without the extra characters. [typo] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Cartodiagram label appears with malformed characters. - ⚠️ French UI quality degraded for this chart. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. The Cartodiagram visualization type is registered in the frontend at `superset/superset-frontend/plugins/plugin-chart-cartodiagram/src/CartodiagramPlugin.tsx` (referenced in `MainPreset.ts`), which uses the msgid `Cartodiagram` for the viz label. 2. In the gettext template `superset/translations/messages.pot` around the Cartodiagram entries, the source label is `msgid "Cartodiagram"`. 3. In the French catalog `superset/translations/fr/LC_MESSAGES/messages.po` at line 2959, the translation is `msgstr "Diagramme cartographique\"es"`, containing an extraneous `\"es` suffix. 4. When a French user opens the chart type picker that lists “Cartodiagram”, the label is rendered from `messages.po:2959`, showing `Diagramme cartographique"es`, which is visibly broken and unprofessional. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3983059a1db44be4924eabcf485ab761&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3983059a1db44be4924eabcf485ab761&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 2959:2959 **Comment:** *Typo: This translation contains an obvious malformed suffix and stray quote (`\"es`), producing broken UI text. Replace it with a clean French term for cartodiagram without the extra characters. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=3c44ea76988d5edcb8d3e87dc04a217820df9fd88ceb2ca77f00ea16ad83d5d7&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=3c44ea76988d5edcb8d3e87dc04a217820df9fd88ceb2ca77f00ea16ad83d5d7&reaction=dislike'>👎</a> ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -3682,17 +3599,14 @@ msgstr "Couleur" msgid "Color +/-" msgstr "Couleur +/-" -#, fuzzy msgid "Color By X-Axis" -msgstr "Colorer par" +msgstr "Colorer par axe X" -#, fuzzy msgid "Color By Y-Axis" -msgstr "Colorer par" +msgstr "Colorer par axe Y" -#, fuzzy msgid "Color Metric" -msgstr "Mesure de couleur" +msgstr "Colour de la mesure" Review Comment: **Suggestion:** This translation uses English spelling (`Colour`) inside a French message, creating inconsistent terminology in the UI. Replace it with the correct French word to keep localization coherent. [inconsistent naming] <details> <summary><b>Severity Level:</b> Minor 🧹</summary> ```mdx - ⚠️ Color metric control shows mixed-language label. - ⚠️ French localization consistency slightly degraded. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. In `superset/translations/messages.pot` near line 3608, the control label for the color metric selector is defined as `msgid "Color Metric"`. 2. In the French catalog `superset/translations/fr/LC_MESSAGES/messages.po` at line 3609, the translation is `msgstr "Colour de la mesure"`, using the English spelling “Colour” inside an otherwise French phrase. 3. The chart configuration UI that exposes the “Color Metric” control uses this msgid; when the current language is French, the control caption is taken from `messages.po:3609`. 4. French users see a label mixing English orthography and French (`Colour de la mesure`), which is inconsistent with other French translations and slightly confusing. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=8809d20e207a4b9697632cce791a1ec2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=8809d20e207a4b9697632cce791a1ec2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 3609:3609 **Comment:** *Inconsistent Naming: This translation uses English spelling (`Colour`) inside a French message, creating inconsistent terminology in the UI. Replace it with the correct French word to keep localization coherent. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=91f6aa359c05b66a148aa1d1523e4922d95adc65b9c8c3e27f4520ac6f7f3806&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=91f6aa359c05b66a148aa1d1523e4922d95adc65b9c8c3e27f4520ac6f7f3806&reaction=dislike'>👎</a> ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -14862,15 +14094,13 @@ msgstr "" "total de sept périodes. Cela cachera la \"hausse\" qui a lieu au cours " "des sept premières périodes" -#, fuzzy msgid "" "The minimum value of metrics. It is an optional configuration. If not " "set, it will be the minimum value of the data" -msgstr "La valeur maximale des mesures. Il s’agit d’une configuration optionnelle" +msgstr "La valeur maximale des mesures. Il s'agit d'une configuration optionnelle" Review Comment: **Suggestion:** This translation inverts the meaning of the source (`minimum` becomes `maximum`), which can mislead users when configuring metric bounds. Translate it to “valeur minimale” to preserve the original behavior description. [comment mismatch] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ French help text mislabels metric minimum. - ⚠️ Users may misconfigure metric bounds. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. In `superset/translations/messages.pot` at lines 14098-14099, the help text source for a chart control is defined as `msgid "The minimum value of metrics. It is an optional configuration. If not set, it will be the minimum value of the data"`, clearly referring to a minimum threshold. 2. In the French catalog `superset/translations/fr/LC_MESSAGES/messages.po` at line 14100, the translation is `"La valeur maximale des mesures. Il s'agit d'une configuration optionnelle"`, which describes a maximum value instead of a minimum. 3. When a user opens a chart configuration panel that uses this help text (any control bound to that msgid in the frontend), the i18n layer fetches the French `msgstr` from `messages.po:14100`. 4. A French-speaking user configuring metric bounds is told they are setting a “valeur maximale” while the control actually sets a minimum, increasing the risk of misconfigured thresholds and confusing behavior. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=fe6ccab61f8f4afca69595406f5b0cde&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=fe6ccab61f8f4afca69595406f5b0cde&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 14100:14100 **Comment:** *Comment Mismatch: This translation inverts the meaning of the source (`minimum` becomes `maximum`), which can mislead users when configuring metric bounds. Translate it to “valeur minimale” to preserve the original behavior description. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=3cd6ab0c6fbaaf105a06f7ee3332ecef6c57b7369789124f38a6dda1cf848117&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=3cd6ab0c6fbaaf105a06f7ee3332ecef6c57b7369789124f38a6dda1cf848117&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
