codeant-ai-for-open-source[bot] commented on code in PR #42095:
URL: https://github.com/apache/superset/pull/42095#discussion_r3591290714
##########
tests/unit_tests/models/helpers_test.py:
##########
@@ -2157,6 +2157,117 @@ def
test_adhoc_metric_to_sqla_invalid_sql_expression_raises_validation_error(
table.adhoc_metric_to_sqla(metric, {})
+def test_adhoc_metric_normalizes_rendered_sql_once(
+ database: Database,
+ mocker: MockerFixture,
+) -> None:
+ from superset.connectors.sqla.models import SqlaTable
+
+ table = SqlaTable(database=database, schema=None, table_name="t")
+ normalizer = mocker.patch.object(
+ table.db_engine_spec,
+ "normalize_custom_sql_metric",
+ return_value="SELECT DATE_TRUNC('quarter', a)",
+ )
+ template_processor = MagicMock()
+ template_processor.process_template.side_effect = (
+ lambda expression: expression.replace("{{ unit }}", "QUARTER")
+ )
Review Comment:
**Suggestion:** Replace the inline lambda with a small local helper function
that includes explicit parameter and return type hints, then assign that
function to `side_effect`. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The added code introduces an untyped lambda function in new Python code.
Under the type-hints rule, this is a real omission because the logic can be
rewritten as a local helper function with explicit parameter and return
annotations.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e6facfdf37e2494f9c9cb211ecf263df&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e6facfdf37e2494f9c9cb211ecf263df&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/models/helpers_test.py
**Line:** 2173:2175
**Comment:**
*Custom Rule: Replace the inline lambda with a small local helper
function that includes explicit parameter and return type hints, then assign
that function to `side_effect`.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42095&comment_hash=e9105cd5a4045a276597051729850efeb0152bb1a16685661d92d40b3b1c143a&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42095&comment_hash=e9105cd5a4045a276597051729850efeb0152bb1a16685661d92d40b3b1c143a&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
