mikebridge commented on PR #42095: URL: https://github.com/apache/superset/pull/42095#issuecomment-4993926254
Addressed the review feedback in `a99bb879e0`: - isolated generic expression validation from metric-specific normalization; - added `pg_catalog.DATE_TRUNC` and `postgres` backend alias handling; - preserved trailing-semicolon cleanup and propagated fallback validation errors; - added the requested explicit test typing and replaced the inline lambda; - moved normalization-service coverage to `tests/unit_tests/sql/metric_normalization_tests.py`. Validation: `pre-commit run --all-files` passed, 257 affected unit tests passed, and the focused integration suite produced 4 passes plus 1 environment-dependent PostgreSQL skip. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
