codeant-ai-for-open-source[bot] commented on code in PR #42095: URL: https://github.com/apache/superset/pull/42095#discussion_r3596794188
########## tests/integration_tests/sqla_models_tests.py: ########## @@ -73,6 +73,53 @@ } [email protected]( + "expression, expected_comment", + [ + ("DATE_TRUNC('QUARTER', created_at) /* inline */", "/* inline */"), + ("DATE_TRUNC('QUARTER', created_at) -- trailing", "/* trailing */"), + ], +) +def test_saved_postgresql_metric_preserves_normalized_source_and_comments( + expression: str, + expected_comment: str, +) -> None: + database = Database(database_name="postgres", sqlalchemy_uri="postgresql://") + table = SqlaTable(table_name="orders", database=database) + metric = SqlMetric(metric_name="quarter", expression=expression, table=table) Review Comment: **Suggestion:** Add an explicit type annotation to this newly introduced local variable to comply with the required type-hinting rule for relevant variables. [custom_rule] **Severity Level:** Minor ๐งน <details> <summary><b>Why it matters? โญ </b></summary> The added local variable `metric` is unannotated in newly introduced Python code, and it can be type-hinted, so this matches the required type-hinting rule violation. </details> <details> <summary><b>Rule source ๐ </b></summary> .cursor/rules/dev-standard.mdc (line 28) </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=2c0c9da8be224e9399d79fdfee363792&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=2c0c9da8be224e9399d79fdfee363792&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** tests/integration_tests/sqla_models_tests.py **Line:** 89:89 **Comment:** *Custom Rule: Add an explicit type annotation to this newly introduced local variable to comply with the required type-hinting rule for relevant variables. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42095&comment_hash=a48e084ad03bd13bae440627a194d007187c3c0b6733623bef86d8daf16b3fb2&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42095&comment_hash=a48e084ad03bd13bae440627a194d007187c3c0b6733623bef86d8daf16b3fb2&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
