mikebridge commented on PR #42095: URL: https://github.com/apache/superset/pull/42095#issuecomment-4996882881
Thanks for the follow-up review. We evaluated both additional suggestions: - `may_preserve_source` is intentionally not consumed by `SqlMetric.get_sqla_col()`. That flag tells the ad hoc metric path whether a subsequent sanitization step may safely preserve the normalized source text. The saved-metric path does not perform that subsequent transformation: it passes the already-normalized expression directly to `literal_column`, so threading the flag through `make_sqla_column_compatible` would not affect its behavior. - We are leaving the focused `pg_catalog.DATE_TRUNC` test without a docstring to remain consistent with the surrounding tests, whose names describe the behavior under test. No code changes are needed for these advisory suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
