rusackas commented on PR #41912: URL: https://github.com/apache/superset/pull/41912#issuecomment-4997258137
Thanks @jesperct, good fix, the cards were totally dead before this. One thing before merging though: now that the fallback anchor's gone (to fix the double-nav bug), the `CardStyles` div's `onClick` is mouse-only, no `role="button"`, `tabIndex`, or `onKeyDown`, so keyboard and screen-reader users can't open a saved query card anymore. Bito's thread on that is still open, mind adding keyboard support there? FWIW, I'm adding linting rules around this sort of thing to catch/block it on PRs going forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
