jesperct commented on code in PR #41912:
URL: https://github.com/apache/superset/pull/41912#discussion_r3562193982
##########
superset-frontend/src/features/home/SavedQueries.tsx:
##########
@@ -303,7 +304,10 @@ export const SavedQueries = ({
{queries.length > 0 ? (
<CardContainer showThumbnails={showThumbnails}>
{queries.map(q => (
- <CardStyles key={q.id}>
+ <CardStyles
+ key={q.id}
+ onClick={() => history.push(`/sqllab?savedQueryId=${q.id}`)}
+ >
Review Comment:
Good catch. I removed the redundant `url` prop so the card wrapper `onClick`
is the only navigation path. That drops the competing anchor entirely, so the
double navigation and the modified-click behavior are both resolved. Added a
regression test asserting the card renders no saved query link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
