bito-code-review[bot] commented on code in PR #41912:
URL: https://github.com/apache/superset/pull/41912#discussion_r3562670662
##########
superset-frontend/src/features/home/SavedQueries.tsx:
##########
@@ -297,11 +298,12 @@ export const SavedQueries = ({
{queries.length > 0 ? (
<CardContainer showThumbnails={showThumbnails}>
{queries.map(q => (
- <CardStyles key={q.id}>
+ <CardStyles
+ key={q.id}
+ onClick={() => history.push(`/sqllab?savedQueryId=${q.id}`)}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Accessibility: non-semantic clickable div</b></div>
<div id="fix">
The `<CardStyles>` wrapper is now a clickable `<div>` without keyboard
accessibility support. Add `role='button'` and `tabIndex={0}` so keyboard users
can focus and activate the card, and handle Enter key via `onKeyDown`.
</div>
</div>
<small><i>Code Review Run #9d9360</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
