rusackas commented on PR #35459: URL: https://github.com/apache/superset/pull/35459#issuecomment-4999278615
Thanks for this, @SBIN2010! One thing before we can merge: @EnxDev's comment about the lateral half-donut case (startAngle 90/270 with sweptAngle ≤180) is still open, the arc ends up pushed to one side since `getHalfDonut` only handles top and bottom. Might be worth adding left/right centering too, or just restricting the control description to top/bottom for now. Also there are a bunch of bot comments still open to assess/address/resolve, if you don't mind. Let me know if you want help with that part. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
