Abhiiishek44 commented on PR #41975: URL: https://github.com/apache/superset/pull/41975#issuecomment-5003932068
Thanks for the feedback — I’ve pushed the update. `_get_client` now reads the project only from `engine.url.host`, so a schema placed in `url.database` by `adjust_engine_params` is no longer treated as the BigQuery project. I also updated the service-account and ADC tests to exercise the `adjust_engine_params` path for: - `bigquery://project` - `bigquery:///project` - `bigquery://` with a schema and no configured project -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
