bito-code-review[bot] commented on code in PR #42151:
URL: https://github.com/apache/superset/pull/42151#discussion_r3607222656
##########
superset/translations/zh/LC_MESSAGES/messages.po:
##########
@@ -17529,9 +17529,8 @@ msgstr "总计 (%(aggregatorName)s)"
msgid ""
"Total angle covered by the chart, in degrees. 360° draws a full circle "
-"and 180° draws a half donut. When the sweep is 180° or less and the start"
-" angle is a multiple of 90°, the chart is automatically re-centered to "
-"make use of the empty space."
+"and 180° draws a half donut. Partial arcs are automatically re-centered "
+"and scaled to make use of the available space."
msgstr ""
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to fill the empty `msgstr` is a standard practice
to ensure all user-facing strings are localized. While it is correct that
automated tools may leave these blank when source strings change, manually
updating them ensures the application remains fully translated for users. You
may choose to address this now or defer it to a dedicated translation update
task.
##########
superset/translations/sl/LC_MESSAGES/messages.po:
##########
@@ -16954,9 +16954,8 @@ msgstr "Skupaj (%(aggregatorName)s)"
msgid ""
"Total angle covered by the chart, in degrees. 360° draws a full circle "
-"and 180° draws a half donut. When the sweep is 180° or less and the start"
-" angle is a multiple of 90°, the chart is automatically re-centered to "
-"make use of the empty space."
+"and 180° draws a half donut. Partial arcs are automatically re-centered "
+"and scaled to make use of the available space."
msgstr ""
Review Comment:
<!-- Bito Reply -->
You are correct. In the context of translation files like `messages.po`,
clearing the `msgstr` field when the source `msgid` changes is standard
practice to ensure the string is marked for re-translation. The reviewer's
suggestion to add `#, fuzzy` is an alternative way to handle this, but leaving
it empty is also a valid and common approach for translation workflows.
**superset/translations/sl/LC_MESSAGES/messages.po**
```
msgid ""
"Total angle covered by the chart, in degrees. 360° draws a full circle "
"and 180° draws a half donut. Partial arcs are automatically re-centered "
"and scaled to make use of the available space."
msgstr ""
```
##########
superset/translations/ja/LC_MESSAGES/messages.po:
##########
@@ -14398,9 +14398,8 @@ msgstr "合計 (%(aggregatorName)s)"
msgid ""
"Total angle covered by the chart, in degrees. 360° draws a full circle "
-"and 180° draws a half donut. When the sweep is 180° or less and the start"
-" angle is a multiple of 90°, the chart is automatically re-centered to "
-"make use of the empty space."
+"and 180° draws a half donut. Partial arcs are automatically re-centered "
+"and scaled to make use of the available space."
msgstr ""
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to add a translation for the reworded source
string is not required in this case. As you noted, an empty `msgstr` is the
standard behavior for reworded source strings in this project's translation
workflow, as it signals that the string needs to be updated by the translation
team. You can safely ignore this suggestion.
**superset/translations/ja/LC_MESSAGES/messages.po**
```
msgid ""
"Total angle covered by the chart, in degrees. 360° draws a full circle "
-"and 180° draws a half donut. When the sweep is 180° or less and the start"
-" angle is a multiple of 90°, the chart is automatically re-centered to "
-"make use of the empty space."
+"and 180° draws a half donut. Partial arcs are automatically re-centered "
+"and scaled to make use of the available space."
msgstr ""
```
##########
superset/translations/sr_Latn/LC_MESSAGES/messages.po:
##########
@@ -19574,9 +19574,8 @@ msgstr "Ukupno (%(aggregatorName)s)"
msgid ""
"Total angle covered by the chart, in degrees. 360° draws a full circle "
-"and 180° draws a half donut. When the sweep is 180° or less and the start"
-" angle is a multiple of 90°, the chart is automatically re-centered to "
-"make use of the empty space."
+"and 180° draws a half donut. Partial arcs are automatically re-centered "
+"and scaled to make use of the available space."
msgstr ""
Review Comment:
<!-- Bito Reply -->
The suggestion provided by the reviewer is appropriate for the context of
the translation update. It correctly adapts the Serbian translation to reflect
the updated English source string, ensuring the terminology remains accurate
and descriptive for the new phrasing.
**superset/translations/sr_Latn/LC_MESSAGES/messages.po**
```
msgstr "Ukupan ugao koji grafikon pokriva, u stepenima. 360° crta puni krug,
a 180° crta polukruženu tortu. Delimitčni lukovi se automatski centriraju i
skaliraju da iskoriste dostupan prostor."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
