bito-code-review[bot] commented on code in PR #42151: URL: https://github.com/apache/superset/pull/42151#discussion_r3607222998
########## superset/translations/es/LC_MESSAGES/messages.po: ########## @@ -16831,9 +16831,8 @@ msgstr "Total (%(aggregatorName)s)" msgid "" "Total angle covered by the chart, in degrees. 360° draws a full circle " -"and 180° draws a half donut. When the sweep is 180° or less and the start" -" angle is a multiple of 90°, the chart is automatically re-centered to " -"make use of the empty space." +"and 180° draws a half donut. Partial arcs are automatically re-centered " +"and scaled to make use of the available space." msgstr "" Review Comment: <!-- Bito Reply --> The empty `msgstr` is indeed expected behavior for reworded strings in `pybabel` when the original `msgid` has changed. Since the translation needs to be updated to match the new English text, you can proceed with providing the updated Spanish translation for this tooltip. **superset/translations/es/LC_MESSAGES/messages.po** ``` msgid "" "Total angle covered by the chart, in degrees. 360° draws a full circle " "and 180° draws a half donut. Partial arcs are automatically re-centered " "and scaled to make use of the available space." msgstr "" ``` ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -16859,9 +16859,8 @@ msgstr "Total (%(aggregatorName)s)" msgid "" "Total angle covered by the chart, in degrees. 360° draws a full circle " -"and 180° draws a half donut. When the sweep is 180° or less and the start" -" angle is a multiple of 90°, the chart is automatically re-centered to " -"make use of the empty space." +"and 180° draws a half donut. Partial arcs are automatically re-centered " +"and scaled to make use of the available space." msgstr "" Review Comment: <!-- Bito Reply --> The reviewer's suggestion to add a French translation for the updated text is correct in principle, as the current entry has an empty `msgstr`. However, if this is a known behavior where `pybabel` intentionally leaves `msgstr` empty for updated source strings to be filled later, you can disregard the suggestion. You may choose to ignore this comment if the empty state is expected for your translation workflow. ########## superset/translations/it/LC_MESSAGES/messages.po: ########## @@ -21866,9 +21866,8 @@ msgstr "Totale (%(aggregatorName)s)" msgid "" "Total angle covered by the chart, in degrees. 360° draws a full circle " -"and 180° draws a half donut. When the sweep is 180° or less and the start" -" angle is a multiple of 90°, the chart is automatically re-centered to " -"make use of the empty space." +"and 180° draws a half donut. Partial arcs are automatically re-centered " +"and scaled to make use of the available space." msgstr "" Review Comment: <!-- Bito Reply --> The empty `msgstr` in this context is intentional and does not require a translation, as it is expected behavior for this specific message entry. You can safely ignore this suggestion. ########## superset/translations/ca/LC_MESSAGES/messages.po: ########## @@ -16851,9 +16851,8 @@ msgstr "Total (%(aggregatorName)s)" msgid "" "Total angle covered by the chart, in degrees. 360° draws a full circle " -"and 180° draws a half donut. When the sweep is 180° or less and the start" -" angle is a multiple of 90°, the chart is automatically re-centered to " -"make use of the empty space." +"and 180° draws a half donut. Partial arcs are automatically re-centered " +"and scaled to make use of the available space." msgstr "" Review Comment: <!-- Bito Reply --> The reviewer's suggestion to add a Catalan translation for the sweep angle description is correct. While empty `msgstr` entries are sometimes expected in `pybabel` workflows for reworded strings, providing the translation ensures a complete localized experience for Catalan users. You should proceed with adding the translation to the `messages.po` file. ########## superset/translations/sl/LC_MESSAGES/messages.po: ########## @@ -16954,9 +16954,8 @@ msgstr "Skupaj (%(aggregatorName)s)" msgid "" "Total angle covered by the chart, in degrees. 360° draws a full circle " -"and 180° draws a half donut. When the sweep is 180° or less and the start" -" angle is a multiple of 90°, the chart is automatically re-centered to " -"make use of the empty space." +"and 180° draws a half donut. Partial arcs are automatically re-centered " +"and scaled to make use of the available space." msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing translation for updated msgid</b></div> <div id="fix"> The 'Total angle covered by the chart' msgid has been updated but `msgstr` remains empty. This means Slovenian users will see English help text instead of a translated string. Per BITO.md [13343], all user-facing messages must have complete translations for every supported language — empty msgstr fields degrade user experience for non-English speakers. Either provide the translation or add `#, fuzzy` to mark it for review. </div> </div> <div><details><summary><b>Review Rule</b></summary><div>Bito created the rule <strong><code>Missing translation for user‑facing string</code></strong> for <strong>repo:</strong> <code>apache/superset</code>, <strong>language:</strong> <code>Gettext Catalog</code>. Bito will avoid suggestions that match this rule. You can manage review rules <a href=https://alpha.bito.ai/home/ai-agents/review-rules>here</a>.</div></details></div> <small><i>Code Review Run #ac672d</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
