amaannawab923 commented on code in PR #42241:
URL: https://github.com/apache/superset/pull/42241#discussion_r3615212884
##########
superset-frontend/src/SqlLab/actions/sqlLab.test.ts:
##########
@@ -734,7 +734,7 @@ describe('async actions', () => {
// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from
describe blocks
describe('popSavedQuery', () => {
const supersetClientGetSpy = jest.spyOn(SupersetClient, 'get');
- const store = mockStore({});
+ const store = mockStore(initialState);
Review Comment:
Only popSavedQuery has an error-path test. the other four (popPermalink,
popStoredQuery, popQuery, popDatasourceQuery) get the same fallback but no
assertion that addNewQueryEditor fires on failure. could we add coverage for
those too, or a shared table-driven case, so the contract is locked for all
five?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
