alexandrusoare commented on code in PR #42241:
URL: https://github.com/apache/superset/pull/42241#discussion_r3621141223
##########
superset-frontend/src/SqlLab/actions/sqlLab.ts:
##########
@@ -1530,7 +1530,10 @@ export function popPermalink(key: string):
SqlLabThunkAction<Promise<unknown>> {
}),
),
)
- .catch(() => dispatch(addDangerToast(ERR_MSG_CANT_LOAD_QUERY)));
+ .catch(() => {
+ dispatch(addDangerToast(ERR_MSG_CANT_LOAD_QUERY));
+ dispatch(addNewQueryEditor());
Review Comment:
Imo narrowing to 404 would still leave the skeleton stuck on a 500 — which
is the original bug that this PR aims to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
