alexandrusoare commented on code in PR #42241:
URL: https://github.com/apache/superset/pull/42241#discussion_r3621186485
##########
superset-frontend/src/SqlLab/actions/sqlLab.ts:
##########
@@ -1632,9 +1644,10 @@ export function popDatasourceQuery(
}),
),
)
- .catch(() =>
- dispatch(addDangerToast(t("The datasource couldn't be loaded"))),
- );
+ .catch(() => {
+ dispatch(addDangerToast(t("The datasource couldn't be loaded")));
+ dispatch(addNewQueryEditor());
Review Comment:
I do understand your point but I think this matches existing behavior —
clicking a saved query always opens a new tab, even if you click it multiple
times. The error path is consistent with the success path: you get a new tab
either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
