michael-s-molina commented on PR #42088: URL: https://github.com/apache/superset/pull/42088#issuecomment-5036662531
Thanks for the review! All three of these are fixed in 4292578: - `buildQuery.ts`: moved the `all_records` percent-metric extra query to build from the fully-filtered `queryObject`, after the interactive group-by/search/AG Grid filter mutations. - `processors.py`: the migration now applies the `extra_form_data.time_compare` and `extra_form_data.time_grain_sqla` overrides (mirroring buildQuery.ts), and expands percent-metric labels with time-offset suffixes when time comparison is on. Added regression tests for all three. - `AgGridTable/index.tsx`: the client-view dedup signature now includes the ordered filtered+sorted node ids, so it catches sorts/filter swaps that don't change row count. I also went through the rest of the codeant threads individually — replied on each with what was fixed vs. left as-is (one `any`-cast pair I left alone since it mirrors an existing pattern in the V1 table plugin and "fixing" it properly would mean widening a shared core type). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
