codeant-ai-for-open-source[bot] commented on code in PR #42088: URL: https://github.com/apache/superset/pull/42088#discussion_r3624017827
########## superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/getTimeRangeFromGranularity.ts: ########## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { TimeGranularity } from '@superset-ui/core'; + +/** + * Calculates the inclusive/exclusive temporal range for a bucket. + * standard SQL range pattern: [start, end) + */ +export default function getTimeRangeFromGranularity( + startTime: Date, + granularity: TimeGranularity, +): [Date, Date] { + const time = startTime.getTime(); + const date = startTime.getUTCDate(); + const month = startTime.getUTCMonth(); + const year = startTime.getUTCFullYear(); + + // Constants + const MS_IN_SECOND = 1000; + const MS_IN_MINUTE = 60 * MS_IN_SECOND; + const MS_IN_HOUR = 60 * MS_IN_MINUTE; + + switch (granularity) { + case TimeGranularity.SECOND: + return [startTime, new Date(time + MS_IN_SECOND)]; + case TimeGranularity.MINUTE: + return [startTime, new Date(time + MS_IN_MINUTE)]; + case TimeGranularity.FIVE_MINUTES: + return [startTime, new Date(time + MS_IN_MINUTE * 5)]; + case TimeGranularity.TEN_MINUTES: + return [startTime, new Date(time + MS_IN_MINUTE * 10)]; + case TimeGranularity.FIFTEEN_MINUTES: + return [startTime, new Date(time + MS_IN_MINUTE * 15)]; + case TimeGranularity.THIRTY_MINUTES: + return [startTime, new Date(time + MS_IN_MINUTE * 30)]; + case TimeGranularity.HOUR: + return [startTime, new Date(time + MS_IN_HOUR)]; + case TimeGranularity.DAY: + case TimeGranularity.DATE: + return [startTime, new Date(Date.UTC(year, month, date + 1))]; + case TimeGranularity.WEEK: + case TimeGranularity.WEEK_STARTING_SUNDAY: + case TimeGranularity.WEEK_STARTING_MONDAY: + return [startTime, new Date(Date.UTC(year, month, date + 7))]; + case TimeGranularity.WEEK_ENDING_SATURDAY: + case TimeGranularity.WEEK_ENDING_SUNDAY: + // Week-ending buckets are labeled by the bucket's final day. + return [ + new Date(Date.UTC(year, month, date - 6)), + new Date(Date.UTC(year, month, date + 1)), + ]; + case TimeGranularity.MONTH: + return [startTime, new Date(Date.UTC(year, month + 1, 1))]; + case TimeGranularity.QUARTER: + return [ + startTime, + new Date(Date.UTC(year, Math.floor(month / 3) * 3 + 3, 1)), + ]; + case TimeGranularity.YEAR: + return [startTime, new Date(Date.UTC(year + 1, 0, 1))]; Review Comment: **Suggestion:** The range start is taken directly from the clicked timestamp for many bucketed granularities, which produces partial bucket filters when the timestamp is not already aligned to the bucket boundary (for example, a DAY value at noon yields `[noon, next-midnight)` instead of the full day). Normalize the start to the granularity boundary before building the range so the temporal filter covers the entire bucket consistently. [logic error] <details> <summary><b>Severity Level:</b> Critical 🚨</summary> ```mdx - ❌ Drill-by filters return partial day/week/month buckets. - ❌ Drill-to-detail shows incomplete results for clicked buckets. - ⚠️ AG Grid table V2 time-bucket interactions inconsistent with V1. - ⚠️ Users may misinterpret metrics based on truncated ranges. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Build and run the Superset frontend including this PR so that the module at `superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/getTimeRangeFromGranularity.ts` is available. 2. From any TypeScript/JavaScript caller (or via the browser console in a page where the AG Grid table plugin is loaded), invoke `getTimeRangeFromGranularity(new Date('2024-01-01T12:00:00Z'), TimeGranularity.DAY)` as defined at line 25 of `getTimeRangeFromGranularity.ts`. 3. Observe the function logic at lines 54–56: for `TimeGranularity.DAY`/`DATE` it returns `[startTime, new Date(Date.UTC(year, month, date + 1))]`, yielding `[2024-01-01T12:00:00Z, 2024-01-02T00:00:00Z)`, which covers only the latter half of the calendar day. 4. Wire this range into a drill-to-detail / drill-by temporal filter (as described in the PR summary for the AG Grid table plugin); when a user drills on the same date bucket, the backend will be filtered to the partial range, returning incomplete results for the bucket instead of the full day/week/month/quarter/year span. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f9580a484b5248759c95952dfe43f94a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f9580a484b5248759c95952dfe43f94a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/getTimeRangeFromGranularity.ts **Line:** 54:76 **Comment:** *Logic Error: The range start is taken directly from the clicked timestamp for many bucketed granularities, which produces partial bucket filters when the timestamp is not already aligned to the bucket boundary (for example, a DAY value at noon yields `[noon, next-midnight)` instead of the full day). Normalize the start to the granularity boundary before building the range so the temporal filter covers the entire bucket consistently. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42088&comment_hash=fcc417e4106a80702cab140a30284998e67399c5826417f98a55db2c047c1378&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42088&comment_hash=fcc417e4106a80702cab140a30284998e67399c5826417f98a55db2c047c1378&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
