justinpark commented on PR #42097:
URL: https://github.com/apache/superset/pull/42097#issuecomment-5038893193
> The flagged issue is correct. Currently, the `TableView` component remains
mounted even when `hideTable` is true, meaning its internal logic continues to
execute during window resizing. To resolve this, you should conditionally
render `TableView` based on the `isSizeStable` state.
>
> Here is the corrected implementation for the return block in
`superset-frontend/src/visualizations/TimeTable/TimeTable.tsx`:
>
> ```tsx
> hideTable={!isSizeStable}
> >
> {isSizeStable && (
> <TableView
> className="table-no-hover"
> columns={memoizedColumns}
> data={data}
> defaultSort={defaultSort}
> />
> )}
> </TimeTableStyles>
> ```
>
> Would you like me to check the rest of the comments on this PR and
implement fixes for them as well?
>
> **superset-frontend/src/visualizations/TimeTable/TimeTable.tsx**
>
> ```
> hideTable={!isSizeStable}
> >
> {isSizeStable && (
> <TableView
> className="table-no-hover"
> columns={memoizedColumns}
> data={data}
> defaultSort={defaultSort}
> />
> )}
> </TimeTableStyles>
> ```
This is intentional — it's meant to prevent the user's sorting or table tab
settings from being reset due to re-mounting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
