rusackas commented on PR #42097: URL: https://github.com/apache/superset/pull/42097#issuecomment-5041580880
Thanks for the explanation above, that clears up my question about toggling visibility instead of unmounting. One more thing to look at is that the new resize/debounce logic in TimeTable.tsx has no test coverage at all, this diff only touches the component file. Could you add a case to TimeTable.test.tsx that dispatches a resize event and asserts the table hides and then reappears after the debounce? It's new stateful behavior with a timer and a listener cleanup, so probably worth stabilizing with a test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
