bito-code-review[bot] commented on code in PR #36889:
URL: https://github.com/apache/superset/pull/36889#discussion_r3634739803
##########
superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.tsx:
##########
@@ -72,10 +72,16 @@ const StyledTabsContainer = styled.div<{ isDragging?:
boolean }>`
}
}
- /* Hide ink-bar during drag */
${({ isDragging }) =>
isDragging &&
`
+ /* Show the drag indicator during drag, over the tab title textarea too */
+ &&,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Invalid CSS selector syntax</b></div>
<div id="fix">
The `&&` selector on line 79 is invalid CSS syntax. In styled-components
template literals, the parent selector is `&` (with a leading colon), not `&&`.
This will cause the cursor: move rule to be silently ignored for the
StyledTabsContainer during drag. The fix is to replace `&&` with `&`.
</div>
</div>
<small><i>Code Review Run #420918</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
