bito-code-review[bot] commented on code in PR #36889:
URL: https://github.com/apache/superset/pull/36889#discussion_r3635465593
##########
superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.tsx:
##########
@@ -72,10 +72,16 @@ const StyledTabsContainer = styled.div<{ isDragging?:
boolean }>`
}
}
- /* Hide ink-bar during drag */
${({ isDragging }) =>
isDragging &&
`
+ /* Show the drag indicator during drag, over the tab title textarea too */
+ &&,
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to replace `&&` with `&` is incorrect in this
context. As you noted, `&&` is a valid and deliberate use of emotion's
parent-selector interpolation, which increases the CSS specificity to (0,3,0).
This is necessary to override the existing `EditableTitle` styles and ensure
the `cursor: move` property is correctly applied during drag operations. You
should disregard the suggestion to change it to `&`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
