EnxDev commented on code in PR #36889:
URL: https://github.com/apache/superset/pull/36889#discussion_r3635465102
##########
superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.tsx:
##########
@@ -72,10 +72,16 @@ const StyledTabsContainer = styled.div<{ isDragging?:
boolean }>`
}
}
- /* Hide ink-bar during drag */
${({ isDragging }) =>
isDragging &&
`
+ /* Show the drag indicator during drag, over the tab title textarea too */
+ &&,
Review Comment:
&& isn't raw CSS it's emotion's parent-selector interpolation, and it
compiles to a doubled class: `.css-x.css-x .editable-title * { cursor: move }`.
Valid CSS, and it is emitted, not ignored.
The doubling is deliberate. It competes with EditableTitle's own
`.css-z.editable-title textarea { cursor: initial }` at `specificity (0,2,1)`.
With `&&` we're at (0,3,0) and win; with a single & we'd be at (0,2,0) and
lose; the cursor stays auto, which is the bug this PR fixes. Verified in
Chromium: && → move, & → auto.
The & rule even comes later in source order and still loses, so it's
specificity, not ordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
