hy144328 commented on PR #42365: URL: https://github.com/apache/superset/pull/42365#issuecomment-5064536078
Converting to draft for now. Unit and integration tests pass. However, pre-commit hook fails, all [PyLint `W9001`](https://github.com/apache/superset/actions/runs/30051744173/job/89355098585?pr=42365), although it did not trigger when I made the commit. It mostly affect the migration scripts. They explicitly commit to the session whereas PyLint seems to prefer transaction context managers. This is also happened with #42277 , and was fixed by [b0bb20f](https://github.com/apache/superset/pull/42277/commits/b0bb20fec58e6b08c0653fff03deb0fbe72fae71). Applying the same fix to all the migration scripts now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
