hy144328 commented on PR #42365: URL: https://github.com/apache/superset/pull/42365#issuecomment-5064564056
> Thanks @hy144328! The pre-commit failure wasn't yours... the pylint hook was pulling migration files into its lint list even though they're meant to be excluded, and migrations legitimately call `session.commit()`. Pushed a one-line fix to the hook config, so hopefully CI goes green now 🤞 OK! Thanks for the quick reply! Saved me a ton of work here. This said, as I have just mentioned, I refactored one migration script yesterday in #42277 . Hope that this is not a problem. https://github.com/apache/superset/pull/42277/changes/b0bb20fec58e6b08c0653fff03deb0fbe72fae71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
